svn commit: r1163558 - /wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java

[mgrigorov]

Author: mgrigorov
Date: Wed Aug 31 09:56:45 2011
New Revision: 1163558

URL: http://svn.apache.org/viewvc?rev=1163558&view=rev
Log:
WICKET-4010 SignInPanel may lead to infinite redirects if there is rememberMe 
cookie with outdated data


Modified:
    
wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java

Modified: 
wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java?rev=1163558&r1=1163557&r2=1163558&view=diff
==============================================================================
--- 
wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java
 (original)
+++ 
wicket/trunk/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/panel/SignInPanel.java
 Wed Aug 31 09:56:45 2011
@@ -116,10 +116,10 @@ public class SignInPanel extends Panel
                // logged in already?
                if (isSignedIn() == false)
                {
+                       IAuthenticationStrategy authenticationStrategy = 
getApplication().getSecuritySettings()
+                               .getAuthenticationStrategy();
                        // get username and password from persistence store
-                       String[] data = getApplication().getSecuritySettings()
-                               .getAuthenticationStrategy()
-                               .load();
+                       String[] data = authenticationStrategy.load();
 
                        if ((data != null) && (data.length > 1))
                        {
@@ -138,6 +138,11 @@ public class SignInPanel extends Panel
                                                        
.newPage(getApplication().getHomePage()));
                                        }
                                }
+                               else
+                               {
+                                       // the loaded credentials are wrong. 
erase them.
+                                       authenticationStrategy.remove();
+                               }
                        }
                }