[
https://issues.apache.org/jira/browse/WICKET-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095230#comment-13095230
]
Martin Grigorov edited comment on WICKET-4009 at 9/1/11 11:08 AM:
------------------------------------------------------------------
Isn't it much easier to modify
org.apache.wicket.page.PageAccessSynchronizer.adapt(...).new
PageManagerDecorator() {...}.getPage(int) to:
@Override
public IManageablePage getPage(int id)
{
lockPage(id);
IManageablePage page = super.getPage(id);
if (page == null) {
// this has to be in finally block
unlockPage(id);
}
return page;
}
There is no unlockPage(int) but we can add it. No need to keep lock if there is
no such page anymore.
was (Author: mgrigorov):
Isn't it much easier to modify
org.apache.wicket.page.PageAccessSynchronizer.adapt(...).new
PageManagerDecorator() {...}.getPage(int) to:
@Override
public IManageablePage getPage(int id)
{
lockPage(id);
IManageablePage page = super.getPage(id);
if (page == null) {
unlockPage(id);
}
return page;
}
There is no unlockPage(int) but we can add it. No need to keep lock if there is
no such page anymore.
> Page Lock on Browser Back Button after Page Expiry
> --------------------------------------------------
>
> Key: WICKET-4009
> URL: https://issues.apache.org/jira/browse/WICKET-4009
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-RC7
> Environment: Wicket version: 1.5-RC7
> java version "1.6.0_25"
> Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
> Java HotSpot(TM) Client VM (build 20.0-b11, mixed mode, sharing)
> Server: GlassFish 3.1.1
> Reporter: bernard
> Attachments: quickStart.zip
>
>
> In the attached quickstart, after page expiry and browser back navigation, a
> server error occurs such as:
> "failed to acquire lock to page 0, attempted for 1 minutes out of allowed 1
> minute"
> This appears to be related to request logging, but I have seen other strange
> errors without request logging such as
> org.apache.wicket.request.handler.ComponentNotFoundException: Could not find
> component 'form' on page 'class web.page.ExpiredPage
> also with browser history back navigation.
> I have seen none of these errors in Wicket 1.4. I guess the reason for not
> having seen this before it that http cache headers are different in 1.5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
