[ 
https://issues.apache.org/jira/browse/WICKET-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095364#comment-13095364
 ] 

Igor Vaynberg commented on WICKET-4008:
---------------------------------------

in the javadoc shouldnt this: index = char | char ; be index = char, { char }?

also i would like to tweak some names to make it easier to comprehend:

property->property name
indexed property->property

other then that looks good. some internal variables will also need to be 
tweaked. ie "readed" is not a word so next_readed will become next_read, but 
these are minor things that can be tweaked later.

+1 to add this to 1.6

> Improve PropertyResolver to use a parser
> ----------------------------------------
>
>                 Key: WICKET-4008
>                 URL: https://issues.apache.org/jira/browse/WICKET-4008
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.6.0
>            Reporter: Pedro Santos
>            Priority: Trivial
>         Attachments: WICKET-4004.patch
>
>
> The usage of a parser is a improvement since it will be able to feedback 
> erroneous property expressions with meaningful exception messages.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to