[ 
https://issues.apache.org/jira/browse/WICKET-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114513#comment-13114513
 ] 

Martin Grigorov commented on WICKET-4085:
-----------------------------------------

This component is simple. Everyone can write it in 5 mins.
And what is wrong with StringResourceModel ? I think it supports this usecase.

In this particular patch I don't like:
- has no tests
- the error handling is bad: 
-- catch "IllegalArgumentException" and report it with #error() ?!
-- catch NPE and re-throw it ?!
- it doesn't take into account the current session locale

But as I said: I think it doesn't deserve to be included.

> Formatted label component
> -------------------------
>
>                 Key: WICKET-4085
>                 URL: https://issues.apache.org/jira/browse/WICKET-4085
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.0, 1.5.1
>            Reporter: Pranav Kacholia
>            Priority: Trivial
>         Attachments: FormattedLabel.patch
>
>
> A component that can be used to display formatted text. Especially numbers 
> example Currency. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to