[ 
https://issues.apache.org/jira/browse/WICKET-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115692#comment-13115692
 ] 

Ronald Tetsuo Miura commented on WICKET-4091:
---------------------------------------------

I don't think I understood the proposal correctly.

Most of the complaints about setOutputMarkupId() I see are around component 
re-rendering in ajax requests, which usually doesn't involve calling 
getMarkupId() (just target.add(component)).

Even if it did (say, we changed target.add(Component) to target.add(String), 
which would be a terrible idea, of course), it's called in the event handling 
time, not in page construction/render time, thus having no effect.

I don't see a solution to this, besides setting it to true on every component 
by default (either by a custom listener or by a built-in setting). And then, 
you'll still have to call setOutputPlaceholderTag() when the components are 
initially invisible.

I vote to make both true by default, or add some one-line setting to do it :)
                
> Automate output of markup ids
> -----------------------------
>
>                 Key: WICKET-4091
>                 URL: https://issues.apache.org/jira/browse/WICKET-4091
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Igor Vaynberg
>              Labels: ajax, markupid
>             Fix For: 1.6.0
>
>
> this is a proposal to remove the rather annoying requirement of having to 
> call setoutputmarkupid(true) on components.
> when a user calls getmarkupid() they are showing intent of using that id, so 
> if that method is called we should automatically call 
> setoutputmarkupid(true). further we should process renderhead() of components 
> first - before rendering the components. most calls to getmarkupid() come 
> from that method so processing it before rendering the component will toggle 
> the correct bit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to