svn commit: r1178361 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java

[mgrigorov]

Author: mgrigorov
Date: Mon Oct  3 09:47:55 2011
New Revision: 1178361

URL: http://svn.apache.org/viewvc?rev=1178361&view=rev
Log:
WICKET-4099 SmartLinkLabel doesn't recognize already tagged links

Minor optimization - don't iterate twice the passed String.


Modified:
    
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java?rev=1178361&r1=1178360&r2=1178361&view=diff
==============================================================================
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/DefaultLinkParser.java
 Mon Oct  3 09:47:55 2011
@@ -81,11 +81,10 @@ public class DefaultLinkParser extends L
        {
                public String buildLink(final String linkTarget)
                {
-                       return "<a href=\"" +
-                               linkTarget +
-                               "\">" +
-                               (linkTarget.indexOf('?') == -1 ? linkTarget : 
linkTarget.substring(0,
-                                       linkTarget.indexOf('?'))) + "</a>";
+                       int indexOfQuestion = linkTarget.indexOf('?');
+                       return "<a href=\"" + linkTarget + "\">" +
+                               (indexOfQuestion == -1 ? linkTarget : 
linkTarget.substring(0, indexOfQuestion)) +
+                               "</a>";
                }
        };