SignInPanel should not always redirect to the Home page when the user is 
signed-in automaticaly with the remember-me feature.
-----------------------------------------------------------------------------------------------------------------------------

                 Key: WICKET-4115
                 URL: https://issues.apache.org/jira/browse/WICKET-4115
             Project: Wicket
          Issue Type: Improvement
    Affects Versions: 1.5.1
            Reporter: Sylvain Vieujot


If a SignInPanel is included in the header of non access protected pages, and 
the users goes directly to a page that is not the home page, the SignInPanel 
will sign him in with the remember-me feature (which is right), but then will 
redirect him to the home page (which is not right if the page is not access 
protected).

See SignInPanel, line 133 & 136.

=> Add an overrideable method like :

protected boolean shouldRedirectToHomePage() {
        return getPage().getClass().isInstance( 
((AuthenticatedWebApplication)getApplication()).getSignInPageClass() );
}

Note : Right now, AuthenticatedWebApplication.getSignInPageClass is protected. 
It has to be changed to public.

That way, if the current page is the sign-in page, the redirect should indeed 
got to the home page if there is no intercept page.
Otherwise, the requested page has probably no restricted access as it has not 
been redirected to the SignIn page. So after the automatic sign-in we should 
just carry on and display the current (and requested) page.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to