[
https://issues.apache.org/jira/browse/WICKET-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132591#comment-13132591
]
Matthias Keller commented on WICKET-4160:
-----------------------------------------
The Problem is that we're limited what we can do with the CSS which is fixed
from external; so we need to change the code instead to add a class to the <ul>.
I see your concern about matching tags but I still think making everything
final just because there's a risk of invalid output in case of wrong overrides
isn't the right solution - there's lots of places where things can be broken
and if it's well documented what is expected from a method then that's always
the risk of the subclasser
> Make AbstractAutoCompleteRenderer.renderHeader() and .renderFooter() non-final
> ------------------------------------------------------------------------------
>
> Key: WICKET-4160
> URL: https://issues.apache.org/jira/browse/WICKET-4160
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.5.1
> Reporter: Matthias Keller
>
> I really love wicket but the times I had to work around final methods just
> increases towards infinity...
> Could you please make in the following class:
> org.apache.wicket.extensions.ajax.markup.html.autocomplete.AbstractAutoCompleteRenderer
> The methods renderHeader and renderFooter non-final? It is really annoying
> in order to just customize the appearance I have to write a whole delegate
> even to an abstract class just to customize that <ul> tag!
> thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
