[ 
https://issues.apache.org/jira/browse/WICKET-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134094#comment-13134094
 ] 

Bertrand Guay-Paquet commented on WICKET-4153:
----------------------------------------------

I know the toolbars don't add themselves :) (except, in a sense, in 
DefaultDataTable)

Your patch is pretty much what I had in mind. In order to not change the 
current appearance of DefaultDataTable, I would have perhaps preserved the 
current location (bottom) of the no records toolbar and added another 
constructor for adding it to the center toolbar.
                
> The tbody section of a DataTable is empty when no records are returned by the 
> provider.
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-4153
>                 URL: https://issues.apache.org/jira/browse/WICKET-4153
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.1
>            Reporter: Bertrand Guay-Paquet
>            Priority: Trivial
>              Labels: datatable
>             Fix For: 1.5.3
>
>         Attachments: DataTable-usePlainTR.diff, DataTable.patch, 
> DataTableTest-usePlainTR.diff, addCenterToolbar.patch, good.png, 
> with_patch.png, without_patch.png
>
>
> When a DataTable is rendered without records, the tbody section is empty. 
> This violates the html spec.
> From the spec:
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row 
> group must contain at least one row, defined by the TR element."
> and
> "The THEAD, TFOOT, and TBODY sections must contain the same number of 
> columns."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to