[ 
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pedro Santos updated WICKET-3899:
---------------------------------

    Attachment: WICKET-3899-fix-test.patch

The attached patch stops the visitor from validate a form if it returns false 
for the visitChildren test.
But it remais weird to me to have to stop the form processing for its own based 
on its configuration for its children.
@devs, If the patch makes sense feel confortable to apply, I'm not sure if it 
is the best option, maybe we need another interface or flag to enable this use 
case with more readability.
                
> IFormVisitorParticipant don't get tested when validation method is visiting 
> inner forms
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-3899
>                 URL: https://issues.apache.org/jira/browse/WICKET-3899
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.17, 1.5-RC5.1
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>         Attachments: WICKET-3899-fix-test.patch, WICKET-3899.patch
>
>
> The inconsistencies is at Form#validate method. It invokes 
> validateNestedForms and validateComponents, but only the second one uses a 
> visitor filter testing for IFormVisitorParticipant#processChildren value.
> More about: http://markmail.org/message/q2qfuyg3gcrurxxp

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to