IPageProvider and its implementations need to be improved
---------------------------------------------------------
Key: WICKET-4201
URL: https://issues.apache.org/jira/browse/WICKET-4201
Project: Wicket
Issue Type: Task
Components: wicket
Affects Versions: 1.5.2, 1.5.1, 1.5.0
Reporter: Emond Papegaaij
During the development op 1.5, IPageProvider and its implementations have
become a bit of a mess. The interface is not clearly defined. One of the
biggest problems is that several methods can throw exceptions and there is no
way of knowing which method will throw which exception and when. It should
always be clear what exceptions to expect. For example, getPage can throw a
PageExpiredException, but getPageClass cannot, it should return null if no page
class is set. Perhaps, it's even better to never throw exceptions at all. Also,
the various introspection methods are not very well defined and make it almost
impossible to come up with an alternative implementation of the interface
(which, IMHO is a sign of a broken API).
Changing this interface is not an option for 1.5, but looking at the number of
subtle bugs that came from this part of the code, it should really be
considered for wicket.next.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
