[ 
https://issues.apache.org/jira/browse/WICKET-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152942#comment-13152942
 ] 

Igor Vaynberg commented on WICKET-3367:
---------------------------------------

doing it this way wont solve the problem of not being able to attach multiple 
behaviors to the same event. we should probably write out the entire handler in 
wicket.event.add() instead of writing it into the attribute.

also, i think adding AjaxAttributes now would be a Good Thing. they stay out of 
the way unless you want to touch them. and, if you are touching the callback 
url in the behavior chances are you will want to rewrite your code using 
attributes because without them it is very fragile. you have to do a 
sql-injeciton-like attack on the url string to even get your own attributes 
into it...so the current way is broken anyways.
                
> Rewrite all JavaScript inline event handlers to be proper attached event 
> handlers
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-3367
>                 URL: https://issues.apache.org/jira/browse/WICKET-3367
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Igor Vaynberg
>             Fix For: 6.0.0
>
>         Attachments: WICKET-3367.patch
>
>
> Currently events added inside onclick, onsubmit attributes are problematic 
> because they cannot be cancelled by other event handlers that are attached to 
> events via javascript's addEventListener() and friends. We should extract all 
> such inlined handlers and attach them via our Wicket.Event api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to