[
https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153225#comment-13153225
]
Peter Pastrnak commented on WICKET-4019:
----------------------------------------
Finally i had time to have a look at the query vs. post parameters problem and
I've realized that there is no access to them in the include, but they are
accessible in the portlet, so the patch was simple, I just had to include
(merge) the portlet request parameters in the url that is forwarded (using
include) to the filter. I've also found out, that without this fix, every ajax
multipart submit creates a new version of the page, as it sends
'wicket-ajax=true' as GET parameters.
Also, I guess, version 1.5.2 started prepending the portlet namespace to a
replaced component twice, as it reuses the old markupId and calls the
onInitializationListener again. To fix this, I've just added a check, if the
prefix is already there.
As soon as I get the commit access on wicket stuff, I can commit these 2 fixes.
As the request query parameters are available in portlet, it would be
definitely worth to get rid off the filter in the portlet support and then
remove the unnecessary response caching. It could bring nice performance
increase, simpler code and one step easier configuration. But for this I need
1-2 days plus run some tests, so maybe I'll have a look at it in December...
I use this page as a notepad (sorry for that), so don't bother reacting...
Maybe once I'll start writing a wiki page ;)...
> Portlet Support 1.5
> -------------------
>
> Key: WICKET-4019
> URL: https://issues.apache.org/jira/browse/WICKET-4019
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5-RC7
> Reporter: Peter Pastrnak
> Attachments: PortletServletRequestWrapper.java, ResponseState.java,
> Wicket - Portlet.htm, wicket-1.5.2.1.zip, wicket-portlet-1.5.0.zip,
> wicket-portlet-1.5.1.1.zip, wicket-portlet-1.5.1.2.zip,
> wicket-portlet-1.5.1.3.zip, wicket-portlet-1.5.1.4.zip,
> wicket-portlet-1.5.1.5.zip, wicket-portlet-1.5.1.zip,
> wicket-portlet-1.5.2.2.zip, wicket-portlet-1.5.2.zip,
> wicket-portlet-1.5.RC7.zip, with bind(this).jpg, without bind(this).jpg
>
>
> Url returned by the RequestMapper does not seem to be properly rendered, as
> it does not encode question mark character in the Url parameter value (I
> haven't checked the w3c spec, but at least Liferay Portal seems to require it
> to be encoded)
> The reason is this definition in the UrlEncoder:
> case QUERY :
> // to allow direct passing of URL in query
> dontNeedEncoding.set('/');
> // to allow direct passing of URL in query
> dontNeedEncoding.set('?');
> Currently URL "http://host/file?param=a?b"; would be encoded as
> "http://host/file?param=a?b";, instead of "http://host/file?param=a%3Fb";
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
