[
https://issues.apache.org/jira/browse/WICKET-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155425#comment-13155425
]
Bertrand Guay-Paquet commented on WICKET-4162:
----------------------------------------------
I had a look at your patch and it looks good.
One observation however: with the previous (flawed) scheme, a resource key
namespace was created for each jar. With your modifications, this is no longer
the case (i.e. a resource key is looked up in all initializers in whatever
order they were added to the application). I don't think this is a problem
presently, but some resource keys could be problematic (e.g. NavigatorLabel,
UploadStatusResource.status, etc.) because they are somewhat generically named.
Should the Wicket built-in resource keys be changed to something prefixed by
the name of the module like "wicket-extensions.whatever"?
As for porting the modifications to 1.5, I don't think anybody had time to
depend on the old resource loader class your patch replaces, so I'd vote for
porting to 1.5.
> Add new StringResourceLoader to allow Wicket extensions to provide
> localization resource bundles
> ------------------------------------------------------------------------------------------------
>
> Key: WICKET-4162
> URL: https://issues.apache.org/jira/browse/WICKET-4162
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5.1
> Reporter: Bertrand Guay-Paquet
> Assignee: Sven Meier
> Labels: extension, localization
> Fix For: 1.5.3
>
> Attachments: WICKET-4162.patch, jar_resource.patch
>
>
> Issue:
> It is currently not possible to provide default localization resource bundles
> for components in wicket extension modules (e.g. wicket-extensions). See
> issues WICKET-3911 and WICKET-4154 where this was a problem.
> Proposed changes:
> 1-Add a new IStringResourceLoader type (WicketExtensionStringResourceLoader?)
> which checks the root of the jar containing the component for properties in
> extension.properties.
> 2-Insert this new resource loader in the existing default resource loader
> chain:
> ResourceSettings() constructor:
> stringResourceLoaders.add(new ComponentStringResourceLoader());
> stringResourceLoaders.add(new PackageStringResourceLoader());
> stringResourceLoaders.add(new
> ClassStringResourceLoader(application.getClass()));
> // New loader inserted here
> stringResourceLoaders.add(new
> WicketExtensionStringResourceLoader());
> stringResourceLoaders.add(new ValidatorStringResourceLoader());
> 3-Start adding extension.properties files in wicket-extension and friends.
> Questions:
> Is a similar effort already underway?
> Are there any better ideas?
> Should the new loader be inserted at the end of the chain instead?
> Do you prefer other names for the loader or the properties file?
> I am prepared to provide a patch sometime next week if this is agreed on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
