[
https://issues.apache.org/jira/browse/WICKET-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172949#comment-13172949
]
Scott Reed commented on WICKET-3607:
------------------------------------
Please document this so users don't have to come here to find out how to use
this feature.
> make ModalWindow CSS contibution more configurable
> --------------------------------------------------
>
> Key: WICKET-3607
> URL: https://issues.apache.org/jira/browse/WICKET-3607
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.17, 1.5-RC3
> Environment: any
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: wicket
> Fix For: 1.4.18, 1.5-RC4
>
> Attachments: ModalWindow.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> Right now if you want to modify the CSS of ModalWindow you still get added to
> page the original CSS as it is included in
> /**
> * Initialize
> */
> private void init()
> {
> setVersioned(false);
> cookieName = null;
> add(empty = new WebMarkupContainer(getContentId()));
> add(newCloseButtonBehavior());
> add(new WindowClosedBehavior());
>
> add(JavascriptPackageResource.getHeaderContribution(JAVASCRIPT));
> add(CSSPackageResource.getHeaderContribution(CSS));
> }
> I propose to do this as
> /**
> * Initialize
> */
> private void init()
> {
> setVersioned(false);
> cookieName = null;
> add(empty = new WebMarkupContainer(getContentId()));
> add(newCloseButtonBehavior());
> add(new WindowClosedBehavior());
>
> add(JavascriptPackageResource.getHeaderContribution(JAVASCRIPT));
> ResourceReference CSS = newCssResource();
> if (CSS != null)
> add(CSSPackageResource.getHeaderContribution(CSS));
> }
> /**
> * Allows to override CSS contribution. Returning null means the CSS
> will be contributed via
> * other sources, e.g. a global CSS resource.
> *
> * @return The CSS resource reference or null if CSS is contributed via
> other means.
> */
> protected ResourceReference newCssResource()
> {
> return CSS;
> }
> This will allow to easily override the CSS file.... or avoid including one
> (returning null)... in case the CSS is part of a "global" page CSS...
> Existing applications will not be affected
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
