[ 
https://issues.apache.org/jira/browse/WICKET-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177186#comment-13177186
 ] 

Emond Papegaaij commented on WICKET-3367:
-----------------------------------------

It seems there are still some problems left. If you search the wicket code for 
Wicket.Ajax.post and Wicket.Ajax.get, you'll find a few calls to the wicket 
AJAX api that still use the old format, which no longer works. Some of them are 
in the deprecated methods in AbstractDefaultAjaxBehavior, but for example 
AjaxFormComponentUpdatingBehavior.getEventHandler also uses the old API (with a 
string). Perhaps these methods should simply be removed? Users who changed the 
generated AJAX scripts probably have no problems upgrading to the new API.

One more thing: AjaxEventBehavior.renderHead checks if the target is AJAX. That 
check is not needed anymore. The IHeaderResponse implementation for AJAX 
requests already renders onDomReady scripts as appended JS.
                
> Rewrite all JavaScript inline event handlers to be proper attached event 
> handlers
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-3367
>                 URL: https://issues.apache.org/jira/browse/WICKET-3367
>             Project: Wicket
>          Issue Type: Sub-task
>            Reporter: Igor Vaynberg
>            Assignee: Martin Grigorov
>             Fix For: 6.0.0
>
>         Attachments: WICKET-3367.patch, WICKET-3367.patch, WICKET-3367.patch, 
> WICKET-3367.patch
>
>
> Currently events added inside onclick, onsubmit attributes are problematic 
> because they cannot be cancelled by other event handlers that are attached to 
> events via javascript's addEventListener() and friends. We should extract all 
> such inlined handlers and attach them via our Wicket.Event api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to