[ 
https://issues.apache.org/jira/browse/WICKET-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181313#comment-13181313
 ] 

Andreas Köhler commented on WICKET-4247:
----------------------------------------

Oh, I missed that. Great decision, btw :-D
                
> HeaderResponseContainerFilteringHeaderResponse does not override enough 
> methods
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-4247
>                 URL: https://issues.apache.org/jira/browse/WICKET-4247
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.3
>            Reporter: Andreas Köhler
>            Assignee: Martin Grigorov
>             Fix For: 1.5.4
>
>         Attachments: 
> 0001-WICKET-4247-override-last-2-renderJavaScript-methods.patch, 
> wicket-4247.tar.bz2
>
>
> Seen on Wicket 1.5.3 and I think it is still there in SVN.
> Major because users might be trapped thinking that their Javascript is at the 
> bottom but it is not, having weird consequences.
> Attached is a quickstart. It sets up a header response decorator with a 
> header response sending javascript to the bottom which is optionally wrapped 
> by a simple implementation of an aggregating header response. The wrapper 
> though uses a full-arguments method to render javascript which is not fetched 
> by the other response header. So the javascript ends up in the html head.
> It should suffice to override the remaining four (js/css, resource ref/url) 
> render methods to fix this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to