WICKET-3367
Rewrite all JavaScript inline event handlers to be proper attached event 
handlers

Javadoc updates.
Remove the handling of 'href' event. This is no more supported


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cd8521ae
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cd8521ae
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cd8521ae

Branch: refs/heads/master
Commit: cd8521aedacd85c0d5aa44757c19c6dff49fa9a2
Parents: 707fc9d
Author: Martin Tzvetanov Grigorov <[email protected]>
Authored: Wed Jan 18 10:05:25 2012 +0100
Committer: Martin Tzvetanov Grigorov <[email protected]>
Committed: Wed Jan 18 10:05:25 2012 +0100

----------------------------------------------------------------------
 .../form/AjaxFormComponentUpdatingBehavior.java    |   18 +++-----------
 1 files changed, 4 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/cd8521ae/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java
 
b/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java
index 93795a0..0ae5305 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java
@@ -81,7 +81,7 @@ public abstract class AjaxFormComponentUpdatingBehavior 
extends AjaxEventBehavio
                        
AjaxFormChoiceComponentUpdatingBehavior.appliesTo(getComponent()))
                {
                        log.warn(String.format(
-                               "AjaxFormComponentUpdatingBehavior is not 
suposed to be added in the form component at path: \"%s\". "
+                               "AjaxFormComponentUpdatingBehavior is not 
supposed to be added in the form component at path: \"%s\". "
                                        + "Use the 
AjaxFormChoiceComponentUpdatingBehavior instead, that is meant for 
choices/groups that are not one component in the html but many",
                                getComponent().getPageRelativePath()));
                }
@@ -107,19 +107,6 @@ public abstract class AjaxFormComponentUpdatingBehavior 
extends AjaxEventBehavio
        }
 
        /**
-        * @see 
org.apache.wicket.ajax.AjaxEventBehavior#onCheckEvent(java.lang.String)
-        */
-       @Override
-       protected void onCheckEvent(String event)
-       {
-               if ("href".equalsIgnoreCase(event))
-               {
-                       throw new IllegalArgumentException(
-                               "this behavior cannot be attached to an 'href' 
event");
-               }
-       }
-
-       /**
         * 
         * @see 
org.apache.wicket.ajax.AjaxEventBehavior#onEvent(org.apache.wicket.ajax.AjaxRequestTarget)
         */
@@ -185,6 +172,7 @@ public abstract class AjaxFormComponentUpdatingBehavior 
extends AjaxEventBehavio
         * has been updated.
         * 
         * @param target
+        *      the current request handler
         */
        protected abstract void onUpdate(AjaxRequestTarget target);
 
@@ -196,7 +184,9 @@ public abstract class AjaxFormComponentUpdatingBehavior 
extends AjaxEventBehavio
         * FormComponent
         * 
         * @param target
+        *       the current request handler
         * @param e
+        *      the error that occurred during the update of the component
         */
        protected void onError(AjaxRequestTarget target, RuntimeException e)
        {

Reply via email to