Updated Branches: refs/heads/wicket-1.5.x 292c5cb1d -> 79d1255b8
WICKET-4357 Calling WebResponse#enableCaching() is insufficient to enable caching on WebPage (which by default is non-cacheable) Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/79d1255b Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/79d1255b Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/79d1255b Branch: refs/heads/wicket-1.5.x Commit: 79d1255b866512d5c008dc0f2b3179906b33cdc4 Parents: 292c5cb Author: Peter Ertl <[email protected]> Authored: Wed Jan 25 20:53:27 2012 +0100 Committer: Peter Ertl <[email protected]> Committed: Wed Jan 25 20:53:27 2012 +0100 ---------------------------------------------------------------------- .../apache/wicket/request/http/WebResponse.java | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/79d1255b/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java ---------------------------------------------------------------------- diff --git a/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java b/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java index 571cbf0..7ed6441 100644 --- a/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java +++ b/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java @@ -194,6 +194,9 @@ public abstract class WebResponse extends Response /** * Make this response cacheable + * <p/> + * when trying to enable caching for web pages check this out: + * <a href="https://issues.apache.org/jira/browse/WICKET-4357";>WICKET-4357</a> * * @param duration * maximum duration before the response must be invalidated by any caches. It should @@ -201,7 +204,7 @@ public abstract class WebResponse extends Response * href="http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html";>RFC-2616</a>. * @param scope * controls which caches are allowed to cache the response - * + * * @see WebResponse#MAX_CACHE_DURATION */ public void enableCaching(Duration duration, final WebResponse.CacheScope scope)
