[ 
https://issues.apache.org/jira/browse/WICKET-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196197#comment-13196197
 ] 

Robert McGuinness commented on WICKET-4356:
-------------------------------------------

i ran into this issue as well, kinda wish the api would fail silently upon 
conversion and return defaults.  Ex:

http://wicket-stateless.herokuapp.com/?counter=8 (works)

but I forgot to check for non ints so the following will fail (will be fixed 
soon)

http://wicket-stateless.herokuapp.com/?counter=fails
                
> StringValueConversionException thrown when calling toInt(final int 
> defaultValue) on StringValue. Why not to return the default value?
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4356
>                 URL: https://issues.apache.org/jira/browse/WICKET-4356
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.3
>            Reporter: Sergei Sizov
>
> In my application I need to get current page parameter from PageParameters
> so I use this code
> PageParameters parameters = ...
> int currentPage = parameters.get("page").toInt(1);
> It works good when "page" parameter contains an Integer value or is null, but 
> when it contains a non numeric value it throws an exception 
> StringValueConversionException.
> I would expect a little bit different behaviour. Why not to return DEFAULT 
> value when StringValueConversionException is thrown? I think it is more 
> secure and saves many lines of code, because you do not need to check that 
> StringValue is really a string containing only numeric characters.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to