[
https://issues.apache.org/jira/browse/WICKET-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212870#comment-13212870
]
Pointbreak commented on WICKET-4425:
------------------------------------
You are right in that he/she should not need to be aware of details of how
wicket TRANSPORTS. He/she should be aware how wicket PARSES templates though.
Thus, that > and < have special meaning in XML/XHTML templates, and will
trigger a parsing error unless used or escaped correctly. Why would the
template parser not simply throw an error on templates that can't be parsed as
valid XML or XHTML? Unbalanced tags in templates also result in parse errors
from wicket (even when they are valid in HTML and accepted by browsers). Your
<div/> vs. <div></div> example has nothing to do with this, as for either
choice the template will be valid/parsable by any XML parser. A script tag that
contains special characters is not. I don't understand why you would want a
parser that accepts and and tries to fix incorrect use of special characters in
scripts tags in template files. Additionally it does a pretty bad job at that.
E.g. try this in a template for an actual error message from the template
parser; just a variation of the same thing though:
<script>
alert("</script>");
</script>
But I fail in getting my message across, so eh.. go ahead, I am happy with your
patch either way. Yet convinced that there is a flawed design decision in the
(new) wicket template processing logic, that your patch not fixes but works
around only for this specific case.
> Wicket 1.5 rewrites template content where it should not
> --------------------------------------------------------
>
> Key: WICKET-4425
> URL: https://issues.apache.org/jira/browse/WICKET-4425
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Pointbreak
> Assignee: Martin Grigorov
> Attachments: WICKET-4425.patch, myproject.zip
>
>
> I have recently upgraded from Wicket 1.4.14 to 1.5.4. One issue that I
> encountered is that <script> tags in panel templates are rewritten by
> Wicket, even when the <script> tags in question have no wicket handlers
> attached to them. I.e. the following panel template (notice that there
> are no wicket:id attributes whatsoever):
> <wicket:panel>
> <script id="template-upload" type="text/x-jquery-tmpl">
> <span>${name}</span>
> </script>
> </wicket:panel>
> Would render in the panel as:
> <script id="template-upload" type="text/x-jquery-tmpl">
> /*<![CDATA[*/
> <span>${name}</span>
> /*]]>*/
> </script>
> Imho this is unwanted behavior that is a regression from the behavior in
> Wicket 1.4.x (or at least 1.4.14). Wicket should not add content to the
> body of the script tags (or any other tags in a template, unless their
> content is provided programmatically), as it does not have the knowledge
> how that affects the functionality of the page. Moreover, the content
> that Wicket adds to these script tags is only correct for Javascript
> (hence incorrect for the scripts in the example as they are not
> javascript). In the above example adding /*, */
> will change the functionality of the script tag. If the "/*<