newResourceResponse() always process IResourceStream
----------------------------------------------------

                 Key: WICKET-4480
                 URL: https://issues.apache.org/jira/browse/WICKET-4480
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 6.0.0-beta1, 1.5.5
            Reporter: Terasaka Kinya
            Priority: Minor


The conditional statement 'if 
(resourceResponse.dataNeedsToBeWritten(attributes))' in 
PackageResource$newResourceResponse always turns true.

dataNeedsToBeWritten() method internally uses its own lastModified field, which 
is null (by default) and always returns true at that point resulting in getting 
a stream and processing it every time.

I think this ruins resource caching.

NOTE: The API document of dataNeedsToBeWritten() exclaims setLastModified() be 
called first.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to