WICKET-4492 some characters are not properly url encoded when used in page parameters
Use JDK6 API String.getBytes(Charset) Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ae61258b Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ae61258b Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ae61258b Branch: refs/heads/sandbox/atmosphere Commit: ae61258b38f1aaae3342360b4c2922cd98ca2978 Parents: 420bf19 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Fri Apr 13 16:26:08 2012 +0300 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Fri Apr 13 16:26:08 2012 +0300 ---------------------------------------------------------------------- .../java/org/apache/wicket/request/UrlEncoder.java | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/ae61258b/wicket-request/src/main/java/org/apache/wicket/request/UrlEncoder.java ---------------------------------------------------------------------- diff --git a/wicket-request/src/main/java/org/apache/wicket/request/UrlEncoder.java b/wicket-request/src/main/java/org/apache/wicket/request/UrlEncoder.java index f3b9ae7..b5db2d1 100644 --- a/wicket-request/src/main/java/org/apache/wicket/request/UrlEncoder.java +++ b/wicket-request/src/main/java/org/apache/wicket/request/UrlEncoder.java @@ -341,15 +341,7 @@ public class UrlEncoder charArrayWriter.flush(); String str = new String(charArrayWriter.toCharArray()); - byte[] ba; - try - { - ba = str.getBytes(charset.name()); - } - catch (UnsupportedEncodingException e) - { - throw new RuntimeException(e); - } + byte[] ba = str.getBytes(charset); for (byte b : ba) { out.append('%');
