Updated Branches: refs/heads/master 79088c993 -> 0754d1bc4
Use logger instead of writing to stderr Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0754d1bc Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0754d1bc Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0754d1bc Branch: refs/heads/master Commit: 0754d1bc4de4a7f44a8fc36240f849a8f434a3ca Parents: 79088c9 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Fri May 11 15:54:06 2012 +0300 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Fri May 11 15:54:06 2012 +0300 ---------------------------------------------------------------------- .../captcha/kittens/KittenCaptchaPanel.java | 8 ++++++-- .../InstrumentationObjectSizeOfStrategy.java | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/0754d1bc/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java index f0e5756..d031571 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java @@ -50,6 +50,8 @@ import org.apache.wicket.request.http.WebResponse; import org.apache.wicket.request.mapper.parameter.PageParameters; import org.apache.wicket.request.resource.DynamicImageResource; import org.apache.wicket.util.time.Time; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * A unique and fun-to-use captcha technique I developed at Thoof. @@ -60,6 +62,8 @@ public class KittenCaptchaPanel extends Panel { private static final long serialVersionUID = 2711167040323855070L; + private static final Logger LOG = LoggerFactory.getLogger(KittenCaptchaPanel.class); + // The background grass area private static BufferedImage grass = load("images/grass.png"); @@ -98,7 +102,7 @@ public class KittenCaptchaPanel extends Panel } catch (IOException e) { - e.printStackTrace(); + LOG.error("Error loading image", e); return null; } } @@ -379,7 +383,7 @@ public class KittenCaptchaPanel extends Panel } catch (IOException e) { - e.printStackTrace(); + LOG.error("Error loading image", e); return null; } } http://git-wip-us.apache.org/repos/asf/wicket/blob/0754d1bc/wicket-objectssizeof-agent/src/main/java/org/apache/wicket/util/instrument/InstrumentationObjectSizeOfStrategy.java ---------------------------------------------------------------------- diff --git a/wicket-objectssizeof-agent/src/main/java/org/apache/wicket/util/instrument/InstrumentationObjectSizeOfStrategy.java b/wicket-objectssizeof-agent/src/main/java/org/apache/wicket/util/instrument/InstrumentationObjectSizeOfStrategy.java index 65f418e..3767884 100644 --- a/wicket-objectssizeof-agent/src/main/java/org/apache/wicket/util/instrument/InstrumentationObjectSizeOfStrategy.java +++ b/wicket-objectssizeof-agent/src/main/java/org/apache/wicket/util/instrument/InstrumentationObjectSizeOfStrategy.java @@ -23,6 +23,8 @@ import java.io.Serializable; import java.lang.instrument.Instrumentation; import org.apache.wicket.core.util.lang.WicketObjects.IObjectSizeOfStrategy; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Object size of strategy that is based on instrumentation. @@ -32,6 +34,8 @@ import org.apache.wicket.core.util.lang.WicketObjects.IObjectSizeOfStrategy; public class InstrumentationObjectSizeOfStrategy implements IObjectSizeOfStrategy { + private static final Logger LOG = LoggerFactory.getLogger(InstrumentationObjectSizeOfStrategy.class); + /** * Records the size of an object and it's dependents as if they were serialized but using the * instrumentation API to calculate. @@ -120,7 +124,7 @@ public class InstrumentationObjectSizeOfStrategy implements IObjectSizeOfStrateg } catch (IOException e) { - e.printStackTrace(); + LOG.error("Error calculating size of object", e); return -1; }
