[
https://issues.apache.org/jira/browse/WICKET-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276106#comment-13276106
]
Jakub Valenta commented on WICKET-4559:
---------------------------------------
I didn't know that. It seems that "idad" is not blocked by AdBlock, so you're
right, this issue does not occur in deployment conf.
As for changing the id: there are dozens of ids blocked by AdBlock, so I think
the chances are pretty high, that one chooses a different id that gets blocked,
too. Not to mention that on large project it might take quite some time to
change all usages of the wrong ids (there might be others, not only "button").
I would feel much safer if getMarkupId() just skipped "ad", like this:
if (generatedMarkupId == 173) {
generatedMarkupId = Session.get().nextSequenceValue();
}
> Component#getMarkupId() generates id that gets hidden by AdBlock
> ----------------------------------------------------------------
>
> Key: WICKET-4559
> URL: https://issues.apache.org/jira/browse/WICKET-4559
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.21
> Reporter: Jakub Valenta
> Attachments: wicket_bug_adblock_project.tar.gz,
> wicket_bug_adblock_screenshot.png
>
>
> Component#getMarkupId() generates ids containing string "ad". Element with
> such id (e.g., "buttonad") is then hidden by the AdBlock plugin (because it
> matches AdBlock's CSS selector #buttonad).
> Since AdBlock is quite a common plugin, this issue might affect most of the
> applications using Wicket.
> Test project and screenshot is attached.
> --
> Wicket 1.4.21
> Firefox 12, AdBlock 2.0.3
> Linux 3.3.5, x86_64
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
