[
https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278666#comment-13278666
]
vineet semwal commented on WICKET-4555:
---------------------------------------
in my opinion it's ok to remove getter but if you want to provide it,i
think it's better to initialize it in getter itself..,
public final PagingNavigation getPagingNavigation()
{
if(pagingNavigation==null){
pagingNavigation=newNavigation("navigation", pageable,
labelProvider);
}
return pagingNavigation;
}
--
thank you,
regards,
Vineet Semwal
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as
> pagingnavigation field in pagingnavigator gets populated in onbeforerender
> and if a user has to use it ,he can only use it in component#onbeforrender
> ie. after pagingnavigator#onbeforerender and at that time too using it might
> *not* give desired result . any one who needs to add some configuration can
> still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
