[ 
https://issues.apache.org/jira/browse/WICKET-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403107#comment-13403107
 ] 

Martin Grigorov edited comment on WICKET-4593 at 6/28/12 2:05 PM:
------------------------------------------------------------------

Hi Sven,

With bf96810d00d0eb916a0425dc413afef6f2fb5b57 you added a call to #updateTab() 
in TabbedPanel#onBeforeRender().
This causes a call to ITab#getPanel() at line 427 for each render of the 
TabbedPanel and thus re-creates the panel for the selected tab and looses the 
state I may have in the previous panel instance.

I believe this is a bug.
It is easy to reproduce with Wicket Examples - 
http://localhost:8080/ajax/tabbed-panel. Click on a tab and you will see that 
ITab#getPanel() is called twice - once by setSelectedTab() and once by 
onBeforeRender(). The real problem is when the TabbedPanel itself is repainted, 
then onBeforeRender() reconstructs the selected tab's panel.
                
      was (Author: mgrigorov):
    Hi Sven,

With bf96810d00d0eb916a0425dc413afef6f2fb5b57 you added a call to #updateTab() 
in TabbedPanel#onBeforeRender().
This causes a call to ITab#getPanel() at line 427 for each render of the 
TabbedPanel and thus re-creates the panel for the selected tab and looses the 
state I may have in the previous panel instance.

I believe this is a bug.

                  
> TabbedPanel bi-directional model
> --------------------------------
>
>                 Key: WICKET-4593
>                 URL: https://issues.apache.org/jira/browse/WICKET-4593
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 6.0.0-beta2
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 6.0.0-RC1
>
>
> TabbedPanel should obey changes in its model, so it could be bound 
> bi-directional to use objects.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to