Updated Branches: refs/heads/wicket-1.5.x 1fe42f0f5 -> 7d8c109e0
WICKET-4641 AjaxFallbackLink and log a warning when there are several ajax event behaviors on the same event Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7d8c109e Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7d8c109e Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7d8c109e Branch: refs/heads/wicket-1.5.x Commit: 7d8c109e0cba8009fa0c730716801250c463cd4d Parents: 1fe42f0 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Tue Jul 24 16:28:53 2012 +0300 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Tue Jul 24 16:28:53 2012 +0300 ---------------------------------------------------------------------- .../wicket/ajax/markup/html/AjaxFallbackLink.java | 29 ++++++++++++++- 1 files changed, 28 insertions(+), 1 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/7d8c109e/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java b/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java index 98dc8ef..e2f4cd7 100644 --- a/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java +++ b/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java @@ -25,11 +25,19 @@ import org.apache.wicket.ajax.calldecorator.CancelEventIfNoAjaxDecorator; import org.apache.wicket.markup.ComponentTag; import org.apache.wicket.markup.html.link.Link; import org.apache.wicket.model.IModel; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * An ajax link that will degrade to a normal request if ajax is not available or javascript is * disabled - * + * + * <p> + * If JavaScript is enabled then the registered JavaScript event 'click' handler will be used, + * otherwise the 'href' attribute if the markup element is an <a>, <area> or <link>. + * AjaxFallbackLink doesn't fallback if the markup element is none of the three above. + * </p> + * * @since 1.2 * * @author Igor Vaynberg (ivaynberg) @@ -38,6 +46,8 @@ import org.apache.wicket.model.IModel; */ public abstract class AjaxFallbackLink<T> extends Link<T> implements IAjaxLink { + private static final Logger LOG = LoggerFactory.getLogger(AjaxFallbackLink.class); + /** */ private static final long serialVersionUID = 1L; @@ -160,4 +170,21 @@ public abstract class AjaxFallbackLink<T> extends Link<T> implements IAjaxLink * ajax target if this linked was invoked using ajax, null otherwise */ public abstract void onClick(final AjaxRequestTarget target); + + @Override + protected void onComponentTag(ComponentTag tag) + { + super.onComponentTag(tag); + + String tagName = tag.getName(); + if ( + LOG.isWarnEnabled() && + !("a".equalsIgnoreCase(tagName) || "area".equalsIgnoreCase(tagName) || "link".equalsIgnoreCase(tagName)) + ) + { + LOG.warn("{} must be used only with <a>, <area> or <link> markup elements. The fallback functionality doesn't" + + " work for other markup elements. Component path: {}, markup element: <{}>.", + new Object[] {AjaxFallbackLink.class.getSimpleName(), getClassRelativePath(), tagName}); + } + } }
