[
https://issues.apache.org/jira/browse/WICKET-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428039#comment-13428039
]
Juha Syrjälä commented on WICKET-4695:
--------------------------------------
By the way, instructions to provide a patch are not correct in
http://wicket.apache.org/contribute/patch.html
git diff should have parameter --cached. Adding changes to index makes them
disappear from git diff.
git add any_files_you_created_modified_or_deleted
git diff --cached > /tmp/fix-WICKET-NNNN.patch
> Javascript error when closing a ModalWindow with IE 8
> -----------------------------------------------------
>
> Key: WICKET-4695
> URL: https://issues.apache.org/jira/browse/WICKET-4695
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.5
> Environment: Internet Explorer 8
> Reporter: Juha Syrjälä
> Priority: Minor
> Labels: ModalWindow, ajax, javascript
> Attachments: fix-WICKET-4695.patch
>
>
> Closing a ModalWindow in IE 8 may cause following javascript error to console:
> 'win.current' is null or not an object
> This doesn't happen with Chrome or Firefox and software seems to work
> correctly: ModalWindow closes correctly etc. This doesn't happen with all
> ModalWindows in my application, but if it happens, it will happen every time.
> I don't know what triggers this behavior, but a work around is to add null
> checks to ModalWindow.java and modal.js, currently there are only check for
> undefined variables.
> ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source
> + "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\"
> && win.current != null) {\n"
> modal.js, Window.close, line 258
> if (typeof(win) != "undefined" && typeof(win.current) != "undefined" &&
> win.current != null) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
