[ https://issues.apache.org/jira/browse/WICKET-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438941#comment-13438941 ]
Emond Papegaaij commented on WICKET-4721: ----------------------------------------- I've come up with 2 solutions, a simple one and a type-safe generic one. I like the idea that this can be solved type-safe, but as you can see from the patch size, it rather large for such a small benefit, and it only includes the fixes in wicket-core. > ConcatBundleResource is unnecessarily limited to accepting > PackageResourceReference > ----------------------------------------------------------------------------------- > > Key: WICKET-4721 > URL: https://issues.apache.org/jira/browse/WICKET-4721 > Project: Wicket > Issue Type: Improvement > Affects Versions: 6.0.0-beta3 > Reporter: Luke Niesink > Assignee: Emond Papegaaij > Priority: Minor > Attachments: WICKET-4721-generics.patch, WICKET-4721-simple.patch > > > ConcatBundleResource (and ConcatResourceBundleReference) are currently > limited to concatenating resources of the type PackageResource. > The only methods of the specified PackageResource's used by > ConcatBundleResource are PackageResource#getCacheKey() and > PackageResource#getResourceStream(). > The implementation of PackageResource#getResourceStream() is (nearly) > identical to PackageResource#getCacheableResourceStream(). > The methods PackageResource#getCacheKey() and > PackageResource#getCacheableResourceStream() are both implemented as part of > the interface IStaticCacheableResource. > ConcatBundleResource (and ConcatResourceBundleReference) should, in my > vision, therefor be able to concatenate all resources that implement > IStaticCacheableResource. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira