[
https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473632#comment-13473632
]
Matthias Gasser commented on WICKET-4019:
-----------------------------------------
I've tried to adopt the given wicket-portlet-1.5.7.2 for wicket 6 and tested on
Liferay 6.1.1.
To do so, I've migrated the files to go well with wicket 6.1.1.
First things noticed:
1) in the PortletFilter a new PortletRequestMapper wrapping a new SystemMapper,
but doing so removes any custom mappings defined in the WebApplication init,
which will turn in a StackOverflowException as no IRequestMapper is in charge
handling the request.
2) so preserved the "old" systemMapper within PortletRequestMapper:
this.systemMapper = (SystemMapper) application.getRootRequestMapper();
3) at this stage, ResourceURLs are missing the portleturl+wicketfilterurl but
wicket portlets showing up again, however images are unrendered, any
functionality posting forms / ajax are going for the wrong url.
Did anybody else trying to adopt this for Wicket 6? Maybe we can share our
experience and make the portlet module wicket 6 ready.
Thx,
> Portlet Support 1.5
> -------------------
>
> Key: WICKET-4019
> URL: https://issues.apache.org/jira/browse/WICKET-4019
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.5-RC7
> Reporter: Peter Pastrnak
> Attachments: ASF.LICENSE.NOT.GRANTED--with bind(this).jpg,
> ASF.LICENSE.NOT.GRANTED--without bind(this).jpg,
> PortletServletRequestWrapper.java, ResponseState.java, wicket-1.5.2.1.zip,
> wicket-portlet-1.5.0.zip, wicket-portlet-1.5.1.1.zip,
> wicket-portlet-1.5.1.2.zip, wicket-portlet-1.5.1.3.zip,
> wicket-portlet-1.5.1.4.zip, wicket-portlet-1.5.1.5.zip,
> wicket-portlet-1.5.1.zip, wicket-portlet-1.5.2.2.zip,
> wicket-portlet-1.5.2.4.zip, wicket-portlet-1.5.2.zip,
> wicket-portlet-1.5.5.0.zip, wicket-portlet-1.5.5.1.zip,
> wicket-portlet-1.5.7.1.zip, wicket-portlet-1.5.7.2.zip,
> wicket-portlet-1.5.RC7.zip, Wicket - Portlet.htm
>
>
> Url returned by the RequestMapper does not seem to be properly rendered, as
> it does not encode question mark character in the Url parameter value (I
> haven't checked the w3c spec, but at least Liferay Portal seems to require it
> to be encoded)
> The reason is this definition in the UrlEncoder:
> case QUERY :
> // to allow direct passing of URL in query
> dontNeedEncoding.set('/');
> // to allow direct passing of URL in query
> dontNeedEncoding.set('?');
> Currently URL "http://host/file?param=a?b"; would be encoded as
> "http://host/file?param=a?b";, instead of "http://host/file?param=a%3Fb";
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
