Updated Branches: refs/heads/master f6f576e20 -> bbd582f9b
Minor performance improvement. No need to make any checks if the input is empty (null or ""). Just return it. Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bbd582f9 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bbd582f9 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bbd582f9 Branch: refs/heads/master Commit: bbd582f9ba9b2e43c79e5afa31b3d3c2e0e900a6 Parents: f6f576e Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Tue Oct 16 11:22:33 2012 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Tue Oct 16 11:47:38 2012 +0200 ---------------------------------------------------------------------- .../apache/wicket/util/encoding/UrlDecoder.java | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/bbd582f9/wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java ---------------------------------------------------------------------- diff --git a/wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java b/wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java index 1bffa23..a950fde 100644 --- a/wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java +++ b/wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java @@ -19,6 +19,8 @@ package org.apache.wicket.util.encoding; import java.io.UnsupportedEncodingException; import java.nio.charset.Charset; +import org.apache.wicket.util.string.Strings; + /** * Adapted from java.net.URLDecoder, but defines instances for query string decoding versus URL path * component decoding. @@ -84,9 +86,9 @@ public class UrlDecoder */ public String decode(final String s, final String enc) { - if (s == null) + if (Strings.isEmpty(s)) { - return null; + return s; } int numChars = s.length();
