[ 
https://issues.apache.org/jira/browse/WICKET-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485833#comment-13485833
 ] 

Chris Colman commented on WICKET-4521:
--------------------------------------

The issue Wicket 4829 , linked to above in "Issue links" will not a problem 
after the suggested patch included in 4829 is applied. The patch works with the 
IMarkupFilters that are also IComponentResolvers by adding a new 
getWicketNamespace method that takes the current MarkupStream as a parameter - 
this then enables the correct namespace to be derived instead of always 
assuming that it's 'wicket'.

A possible refinement of this patch might be to add this new parameter to the 
existing no parameter getWicketNamespace method rather than add a completely 
new method.


                
> Improve all IComponentResolvers which are also IMarkupFilters to set tag ids 
> with common prefix
> -----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4521
>                 URL: https://issues.apache.org/jira/browse/WICKET-4521
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>    Affects Versions: 1.5.6
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 6.0.0-beta2
>
>
> Several IComponentResolvers (like InlineEnclosureHandler and 
> WicketMessageTagHandler) create dynamic Component id from the ComponentTag id 
> + page.getAutoIndex() only if the respective IComponentResolver recognize the 
> ComponentTag id.
> This should be improved and should set the auto index if the ComponentTag id 
> has a predefined namespace.
> See WICKET-4520. There a ComponentTag looks like <div wicket:enclosure=... 
> wicket:message=...> and thus both IMarkupFilters manipulate the ComponentTag 
> but just the first one sets its id. Later InlineEnclosureHandler acting as 
> IComponentResolver sees '_wicket_message_' as tag id and decides to not add 
> the auto index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to