[
https://issues.apache.org/jira/browse/WICKET-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552792#comment-13552792
]
Martin Grigorov commented on WICKET-4967:
-----------------------------------------
I'm not sure we should do this change. This may break the UI for many apps
which are already in production which do not use Twitter Bootstrap.
I see two options:
1) override the CSS rule for the modal window, i.e. revert the changes made by
TB
2) use TB's Modal instead of Wicket-Extensions' one.
> Title (caption) not correctly displayed when using a css framework which
> change the default style of h3.
> --------------------------------------------------------------------------------------------------------
>
> Key: WICKET-4967
> URL: https://issues.apache.org/jira/browse/WICKET-4967
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.4.0
> Reporter: pascal jacob
> Priority: Trivial
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Because the title (a.k.a. the caption) of ModalWindow is displayed within a
> <h3> tag it can miss behave when the application is using a css framework
> which change the default style of h3.
> In fact, bootstrap redefine h3 to have a line-height: 40px; and a font-size:
> 24.5px; in this case, the ModalWindow caption is a lot bigger than usual and
> is not correctly displayed.
> The bug is trivial to fix: have the ModalWindow caption rendered in a span or
> a div tag instead of a h3 tag.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
