Updated Branches:
  refs/heads/wicket-1.5.x 66ebc4b30 -> d235f666e

WICKET-4976 WicketTester#startComponent(Component) doesn't detach the component 
and request cycle


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d235f666
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d235f666
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d235f666

Branch: refs/heads/wicket-1.5.x
Commit: d235f666e7704401b54c2a24a00784d807efc71c
Parents: 66ebc4b
Author: Martin Tzvetanov Grigorov <[email protected]>
Authored: Tue Jan 15 10:30:54 2013 +0200
Committer: Martin Tzvetanov Grigorov <[email protected]>
Committed: Tue Jan 15 10:33:18 2013 +0200

----------------------------------------------------------------------
 .../wicket/util/tester/BaseWicketTester.java       |   16 +++++++++++---
 1 files changed, 12 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/d235f666/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java 
b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
index 5eee438..3e1bfaa 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
@@ -1562,12 +1562,20 @@ public class BaseWicketTester
         */
        public Component startComponent(final Component component)
        {
-               component.internalInitialize();
-               if (component instanceof FormComponent)
+               try
+               {
+                       component.internalInitialize();
+                       if (component instanceof FormComponent)
+                       {
+                               ((FormComponent<?>)component).processInput();
+                       }
+                       component.beforeRender();
+               }
+               finally
                {
-                       ((FormComponent<?>)component).processInput();
+                       getRequestCycle().detach();
+                       component.detach();
                }
-               component.beforeRender();
 
                return component;
        }

Reply via email to