WICKET-5147 javadoc update

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e87c8476
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e87c8476
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e87c8476

Branch: refs/heads/master
Commit: e87c847657454f1a57b23b381b3304ba4f768b11
Parents: 2dc6b4f
Author: Michael Mosmann <[email protected]>
Authored: Tue Apr 23 00:33:25 2013 +0200
Committer: Michael Mosmann <[email protected]>
Committed: Tue Apr 23 00:33:25 2013 +0200

----------------------------------------------------------------------
 .../apache/wicket/util/tester/WicketTester.java    |   17 ++++++++++++++-
 .../wicket/util/tester/WicketTesterTest.java       |    9 +------
 2 files changed, 18 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/e87c8476/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java 
b/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java
index a10eef8..aaec246 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java
@@ -39,6 +39,7 @@ import org.apache.wicket.markup.html.list.ListView;
 import org.apache.wicket.markup.html.panel.FeedbackPanel;
 import org.apache.wicket.model.IModel;
 import org.apache.wicket.protocol.http.WebApplication;
+import org.apache.wicket.protocol.http.mock.MockHttpServletRequest;
 import org.apache.wicket.request.mapper.parameter.PageParameters;
 import org.apache.wicket.util.lang.Objects;
 import org.slf4j.Logger;
@@ -134,7 +135,7 @@ import org.slf4j.LoggerFactory;
  *     tester.assertInfoMessages(new String[] { &quot;Wicket Rocks ;-)&quot; 
});
  * }
  * </pre>
- *
+ * 
  * Many methods require a 'path' parameter. E.g. the page relative path can be 
obtained via
  * {@link Component#getPageRelativePath()}. Since each Component has an 
ID/name, any Component can
  * also be referenced by its ID {@link MarkupContainer#get(String)}. And since 
MarkupContainer's and
@@ -142,6 +143,20 @@ import org.slf4j.LoggerFactory;
  * you may not only access direct childs but also subchilds like 
get("myPanel:myForm:myNameField")
  * separating each ID with a ':'.
  * 
+ * Cookie handling:
+ * 
+ * There are some expectations about wicket tester cookie handling which 
should match as best as
+ * it can be with a real client server request response cycle: 
+ * - all valid cookies set before a request is made 
(tester.getRequest().addCookie()) should
+ *   appear in the page request
+ * - all cookies set in the response should appear in the last response 
(tester.getLastResponse()) 
+ *   after the request is made 
+ * - all cookies set in the response should appear even after a redirect 
response is made
+ *   until the final response (tester.getLastResponse()) is written to the 
client (wicket tester) 
+ * - all valid cookies (maxAge!=0) from the last response should be added or 
should overwrite 
+ *   the next request cookies (not visible in tester.getRequest().getCookies())
+ * 
+ * 
  * TODO General: Example usage of FormTester
  * 
  * @author Ingram Chen

http://git-wip-us.apache.org/repos/asf/wicket/blob/e87c8476/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java 
b/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
index 8ffcdb0..2087a3f 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
@@ -1376,13 +1376,8 @@ public class WicketTesterTest extends WicketTestCase
        }
        
        /**
-        * There are some expectations about wicket tester cookie handling 
which should match as 
-        * best as it can be with a real client server request response cycle:
-        * - all valid cookies set before a request is made should appear in 
the wicket request
-        * - all cookies set in the response should appear in the tester 
response after the request is made
-        * - all cookies set in the response should appear even after a 
redirect response is made until the final response is written to the client
-        * - all valid cookies from the last response should be added or should 
overwrite the next request cookies
-        *
+        * @see WicketTester
+        * 
         * https://issues.apache.org/jira/browse/WICKET-5147
         */
        @Test

Reply via email to