[ 
https://issues.apache.org/jira/browse/WICKET-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644145#comment-13644145
 ] 

Sven Meier commented on WICKET-5085:
------------------------------------

Why not let InlineEnclosure use Wicket's standard HTML id generation? That 
would be far easier than introducing yet another complexity in handling of 
enclosures:

diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
index 3e4d230..d0d16ba 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/InlineEnclosure.java
@@ -58,7 +58,6 @@
 
                // ensure that the Enclosure is ready for ajax updates
                setOutputMarkupPlaceholderTag(true);
-               setMarkupId(getId());
        }
 
        @Override

IMHO this problem would better tracked on a separate issue. What's the fix 
version now?
                
> InlineEnclosure are piling up on each render
> --------------------------------------------
>
>                 Key: WICKET-5085
>                 URL: https://issues.apache.org/jira/browse/WICKET-5085
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.6.0, 1.5.10
>            Reporter: Sven Meier
>            Assignee: Martin Grigorov
>             Fix For: 6.7.0, 1.5.11
>
>
> InlineEnclosureHandler#resolve() uses an auto-incremented id for its resolved 
> InlineEnclosure, 
> On the next render, a new instance will be resolved, since the id of the 
> already resolved InlineEnclosure does not match the id in the markup.
> But InlineEnclosures are not removed after render as other auto-components, 
> thus all instances pile up in the owning container of the markup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to