[
https://issues.apache.org/jira/browse/WICKET-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656085#comment-13656085
]
Jesse Long commented on WICKET-5179:
------------------------------------
Thank you Martin for doing this. Sorry, I should have said so in the report,
but I would also like the default button part extracted too. (I want to avoid
calling Form#onComponentTagBody(), or duplicating any logic in it).
Looking at the code, you would have to add parameters for MarkupStream and
ComponentTag in order to call appendDefaultButtonField() - but
appendDefaultButtonField() doesn't really need these. It would actually be
neater to have appendDefaultButtonField() just take a Response object.
I think we should change this for Wicket 7. (Make appendDefaultButtonField()
take only a Response and call it from writeHiddenField[s]).
It seems like a waste to add a new API writeHiddenField() taking MarkupStream,
ComponentTag and Response in 6.8.0 and which will be immediately incompatible
with the Wicket 7 writeHiddenField that takes only Response. So, I propose we
leave Wicket 6 as it was, and just fix it for wicket 7.
Let me know what you think and I'll put a patch together.
> Move Form hidden field rendering to dedicated method
> ----------------------------------------------------
>
> Key: WICKET-5179
> URL: https://issues.apache.org/jira/browse/WICKET-5179
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.7.0
> Environment: PanelMarkupSourcingStrategy
> Reporter: Jesse Long
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.8.0, 7.0.0
>
>
> Form renders its hidden fields in onComponentTagBody(), which is never called
> when the markup sourcing strategy is PanelMarkupSourcingStrategy. Please can
> we move this to a dedicated method which can be called from
> MarkupSourcingStrategy#onComponentTagBody() when the component is instanceof
> Form.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
