[ 
https://issues.apache.org/jira/browse/WICKET-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687686#comment-13687686
 ] 

Martin Grigorov commented on WICKET-5221:
-----------------------------------------

AbstractSingleSelectChoice works with string concatenation to generate the 
options, while Select's design is to work with proper Components.
In ASSC I see 
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractSingleSelectChoice.java?source=cc#L308-L396,
 i.e. almost 100 lines of code and comments dealing with the nullOption.

Please attach a patch so we can discuss it. Maybe we will find a middle ground 
where everyone is happy.
                
> Add null choice support to Select component like in AbstractSingleSelect
> ------------------------------------------------------------------------
>
>                 Key: WICKET-5221
>                 URL: https://issues.apache.org/jira/browse/WICKET-5221
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket-extensions
>    Affects Versions: 6.8.0
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>            Priority: Minor
>
> Select component in wicket-extensions is designed to be a light one. 
> Nevertheless I think it's ok to add a new variable to it - e.g. nullValid - 
> so we can set the component to support null choices.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to