[
https://issues.apache.org/jira/browse/WICKET-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov resolved WICKET-5273.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.10.0
7.0.0
Modified the check which tabbableTags to disable by allowing tabIndex in all
elements in the Modal Window, not just in the 'content' part. That means now
all tabbable elements in the 'caption' won't be disabled.
> Tabindex overwritten in modal window for IE - Works in FF, Chrome
> -----------------------------------------------------------------
>
> Key: WICKET-5273
> URL: https://issues.apache.org/jira/browse/WICKET-5273
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.9.1
> Reporter: J
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 7.0.0, 6.10.0
>
> Attachments: tabindexinieoverwritten.zip
>
>
> Attribute tabindex gets overwritten in ModalDialog, when using IE 8,9,10.. It
> works fine in FF, Chrome.
> This breaks chances of creating accessability by using tab.
> See attachment for testproject, which works in ff,chrome, fails in ie 8,9,10.
> 1) Open modallink (lightbox)
> 2) use tabbutton - in ff, chrome you'll tab between closebutton and content,
> in ie this fails cause tabindex gets overwritten by -1.
> I suspect it's this codepart in modal.js that does it.
> if (Wicket.Browser.isIE()) {
> this.disabledTabsRevertList = [];
> for (var j = 0; j < this.tabbableTags.length;
> j++) {
> var tagElements =
> doc.getElementsByTagName(this.tabbableTags[j]);
> for (var k = 0 ; k <
> tagElements.length; k++) {
> // if this is not an iframe
> window and the element is child of window content,
> // don't disable tab on it
> if (win.isIframe() === true ||
> this.isParent(tagElements[k], win.content) === false) {
> var element =
> tagElements[k];
> element.hiddenTabIndex
> = element.tabIndex;
> element.tabIndex="-1";
>
> this.disabledTabsRevertList.push(element);
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
