[ 
https://issues.apache.org/jira/browse/WICKET-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl-Eric Menzel resolved WICKET-5305.
--------------------------------------

    Resolution: Fixed

pushed the patch
                
> Make ThrottleSettings#id default to the component's markupId
> ------------------------------------------------------------
>
>                 Key: WICKET-5305
>                 URL: https://issues.apache.org/jira/browse/WICKET-5305
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.0.0
>            Reporter: Carl-Eric Menzel
>            Assignee: Carl-Eric Menzel
>            Priority: Minor
>             Fix For: 7.0.0
>
>         Attachments: 
> 0001-WICKET-5305-make-ThrottleSettings-id-default-to-the-.patch
>
>
> ThrottleSettings#id was until today not well documented. It came up a few 
> times in the trainings and coachings I give and users were all confused about 
> what it's for and why they have to explicitly set it each time.
> I think that in most cases defaulting to a unique value should be sufficient 
> unless you want to combine several events in one throttle.
> I have a commit (not yet pushed) that changes AbstractDefaultAjaxBehavior 
> (where the id is read and sent to the client) so if the id is null it will 
> simply use the current component's markup id, which is guaranteed to be 
> unique.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to