[
https://issues.apache.org/jira/browse/WICKET-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765419#comment-13765419
]
Betlista commented on WICKET-5348:
----------------------------------
Maybe I had to split the "bug" to several bugs, but I feel those parts (wrong
JavaDoc, PropertyColumn declaration and PropertySortParam) are closely related.
> JavaDoc for IColumn#getSortProperty() in misleading
> ---------------------------------------------------
>
> Key: WICKET-5348
> URL: https://issues.apache.org/jira/browse/WICKET-5348
> Project: Wicket
> Issue Type: Bug
> Reporter: Betlista
> Priority: Minor
> Labels: column, columns, properties, property,
> property-expression, sort, table
>
> JavaDoc for getSortProperty() in
> org.apache.wicket.extensions.markup.html.repeater.data.table.IColumn<T, S>
> interface states:
> "Returns the name of the property that this header sorts. If null is returned
> the header will be unsortable."
> According to this JavaDoc I'd expect that it should be String.
> I assume that someone would like to use something other than String. But I
> think that at least for PropertyColumn it has to be bound to String, so
> change the:
> public class PropertyColumn<T, S> extends AbstractColumn<T, S> implements
> IExportableColumn<T, S, Object>
> to:
> public class PropertyColumn<T> extends AbstractColumn<T, String> implements
> IExportableColumn<T, String, Object>
> because referenced PropertyModel is not parameterized with S.
> I also suggest to add PropertySortParam that extends SortParam<String> to
> framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
