[ 
https://issues.apache.org/jira/browse/WICKET-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766315#comment-13766315
 ] 

Betlista commented on WICKET-4535:
----------------------------------

I'll have to check your patches precisely. Your usage seems valid to me. I got 
here, because I reported WICKET-5348 where IColumn changed from IColumn<T> to 
IColumn<T, S> and it seems to me (according to your description), that T = S. 
It seems to me, that while I want DataTable<ROW> - getColumns() returns list of 
IColumn<ROW, COLUMN> while it should be IColumn<COLUMN> principially.

Now, when I checked sources I found I got confused with parameter misuse in 
IColumn (PropertyColumn) and PropertyModel - in IColumn<T> (old version) T is 
type of row, while in PropertyModel<T> T is type of "column".
                
> Inconsistent use of generics in sorting APIs
> --------------------------------------------
>
>                 Key: WICKET-4535
>                 URL: https://issues.apache.org/jira/browse/WICKET-4535
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 6.0.0-beta1
>            Reporter: Jesse Long
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 6.0.0-beta2
>
>         Attachments: myproject.zip, WICKET-4535-1.patch, WICKET-4535-2.patch, 
> WICKET-4535-3.patch, WICKET-4535-4.patch, WICKET-4535-5.patch
>
>
> The Sort APIs use very generics inconsistently. Classes like 
> SortableDataProvider, ISortState, SortParam etc do not all uniformly cater 
> for sort properties other than string. There is a lot of unchecked casting, 
> which is not really required, if generics were used across the board.
> Fixing this will probably cause API changes for 6.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to