Betlista created WICKET-5350:
--------------------------------

             Summary: Enahancement for AbstractChoice and WildcardListModel API
                 Key: WICKET-5350
                 URL: https://issues.apache.org/jira/browse/WICKET-5350
             Project: Wicket
          Issue Type: Improvement
            Reporter: Betlista
            Priority: Minor


According to Efective Java book 
(http://devender.files.wordpress.com/2008/05/effectivejava.pdf), item 28:

"No wildcard type for return value"

Especially "User should not have to think about wildcards to use your API".

so

public List<? extends E> getChoices()

should be changed to

public List<E> getChoices()

and for WildcardListModel

protected List<? extends T> createSerializableVersionOf(List<? extends T> 
object)

should be changed to

protected List<T> createSerializableVersionOf(List<? extends T> object)

Probably there is a lot of such things in framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to