[
https://issues.apache.org/jira/browse/WICKET-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov updated WICKET-5446:
------------------------------------
Description:
>From
>https://issues.apache.org/jira/browse/WICKET-5263?focusedCommentId=13846285&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846285:
| The implementation of isVersion(..) isn't obvious as there naturally is one
problem: The version depends on the resource and the resource isn't
| known without properly stripping the version from the URL. I'd therefore
suggest to the method getVersionPattern() to IResourceVersion.
| The implementations for all current implementations would be trivial:
| LastModifiedResourceVersion: "[0-9]+" = timestamp in ms
| MessageDigestResourceVersion: "[0-9A-F]+" = hex value (uppercase)
| StaticResourceVersion: Pattern.quote(version)
| CachingResourceVersion and RequestCycleCachedResourceVersion:
delegate.getVersionPattern()
| Making this pattern optional (i.e. return null) would retain the current
behavior. Sure, it's still prone to errors (e.g. if version prefix is '-' and
the
| resource is foo-1.png -> foo.png) but at least it avoids some (or probably
most) errors (e.g. foo-bar1.png).
was:
>From WICKET-5263:
TBD
> Improve version matching in resource caching strategies
> -------------------------------------------------------
>
> Key: WICKET-5446
> URL: https://issues.apache.org/jira/browse/WICKET-5446
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.12.0, 7.0.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
>
> From
> https://issues.apache.org/jira/browse/WICKET-5263?focusedCommentId=13846285&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846285:
> | The implementation of isVersion(..) isn't obvious as there naturally is one
> problem: The version depends on the resource and the resource isn't
> | known without properly stripping the version from the URL. I'd therefore
> suggest to the method getVersionPattern() to IResourceVersion.
> | The implementations for all current implementations would be trivial:
> | LastModifiedResourceVersion: "[0-9]+" = timestamp in ms
> | MessageDigestResourceVersion: "[0-9A-F]+" = hex value (uppercase)
> | StaticResourceVersion: Pattern.quote(version)
> | CachingResourceVersion and RequestCycleCachedResourceVersion:
> delegate.getVersionPattern()
> | Making this pattern optional (i.e. return null) would retain the current
> behavior. Sure, it's still prone to errors (e.g. if version prefix is '-' and
> the
> | resource is foo-1.png -> foo.png) but at least it avoids some (or probably
> most) errors (e.g. foo-bar1.png).
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
