Concatenate char instead of String where possible. Use Strings.split() instead of j.l.String#split() - the latter uses regex and is slower
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/69530253 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/69530253 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/69530253 Branch: refs/heads/master Commit: 69530253d3d5170ae5adfb3b7050786ed3b3ff90 Parents: 34eaca2 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Thu Dec 19 12:03:15 2013 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Thu Dec 19 12:03:15 2013 +0200 ---------------------------------------------------------------------- .../java/org/apache/wicket/markup/html/form/AbstractChoice.java | 4 ++-- .../extensions/markup/html/form/palette/component/Recorder.java | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/69530253/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java index 9a46891..e91ba36 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java @@ -388,7 +388,7 @@ public abstract class AbstractChoice<T, E> extends FormComponent<T> buffer.append("\n<option "); setOptionAttributes(buffer, choice, index, selected); - buffer.append(">"); + buffer.append('>'); String display = displayValue; if (localizeDisplayValues()) @@ -432,7 +432,7 @@ public abstract class AbstractChoice<T, E> extends FormComponent<T> buffer.append("value=\""); buffer.append(Strings.escapeMarkup(renderer.getIdValue(choice, index))); - buffer.append("\""); + buffer.append('"'); } /** http://git-wip-us.apache.org/repos/asf/wicket/blob/69530253/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java index 9985066..64fa895 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java @@ -28,6 +28,7 @@ import org.apache.wicket.extensions.markup.html.form.palette.Palette; import org.apache.wicket.markup.html.form.HiddenField; import org.apache.wicket.markup.html.form.IChoiceRenderer; import org.apache.wicket.model.Model; +import org.apache.wicket.util.string.Strings; /** @@ -103,7 +104,7 @@ public class Recorder<T> extends HiddenField<String> modelStringBuffer.append(renderer.getIdValue(selection.next(), i++)); if (selection.hasNext()) { - modelStringBuffer.append(","); + modelStringBuffer.append(','); } } @@ -133,7 +134,7 @@ public class Recorder<T> extends HiddenField<String> idForChoice.put(choice, renderer.getIdValue(choice, 0)); } - for (final String id : getValue().split(",")) + for (final String id : Strings.split(getValue(), ',')) { for (final T choice : choices) {
