[ 
https://issues.apache.org/jira/browse/WICKET-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865256#comment-13865256
 ] 

Martin Grigorov commented on WICKET-5464:
-----------------------------------------

I'm -0.
The fact that #restart() and #stop() no longer update the component is a good 
improvement!
If the application depends on this then it can add the component in #onTimer() 
explicitly.
But still this is a functional change that may introduce regression in some 
apps and users don't expect such changes in minor updates.

> AbstractAjaxTimerBehavior does not work in combination with Wizards
> -------------------------------------------------------------------
>
>                 Key: WICKET-5464
>                 URL: https://issues.apache.org/jira/browse/WICKET-5464
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.12.0
>            Reporter: Marcus Thiesen
>         Attachments: ajaxwizard-quickstart.tar.bz2
>
>
> AbstractAjaxTimerBehavior calls stop() in it's onRemove() method. When used 
> in a Wizard onRemove is triggered by onActiveStepChanged. This disabled, but 
> never re-enables the behavior if the component tree is reused during wizard 
> stepping. 
> In my opinion it is more correct to disable the frontend timer but keep the 
> internal state of the Bahavior as is (or resetting headRendered to false as 
> the Behavior is in the pre render state after the onRemove) in order to 
> re-enable the Timer when the step using the Behavior is rendered again.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to