minor non-functiolal changes: - format the javadoc - chain the constructors - remove javadoc that is inherited anyway
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e01153f6 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e01153f6 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e01153f6 Branch: refs/heads/sandbox/WICKET-4686 Commit: e01153f618e0038dd69b001e750ce13b90b30cfe Parents: 463e603 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Fri Dec 20 14:00:59 2013 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Fri Dec 20 14:00:59 2013 +0200 ---------------------------------------------------------------------- .../wicket/markup/html/form/ChoiceRenderer.java | 27 ++++++++------------ 1 file changed, 11 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/e01153f6/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ChoiceRenderer.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ChoiceRenderer.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ChoiceRenderer.java index 75220ed..1134c14 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ChoiceRenderer.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ChoiceRenderer.java @@ -69,19 +69,21 @@ public class ChoiceRenderer<T> implements IChoiceRenderer<T> private final String idExpression; /** - * Construct. When you use this constructor, the display value will be determined by calling + * Constructor. + * + * When you use this constructor, the display value will be determined by calling * toString() on the list object, and the id will be based on the list index. the id value will * be the index */ public ChoiceRenderer() { - super(); - this.displayExpression = null; - this.idExpression = null; + this(null); } /** - * Construct. When you use this constructor, the display value will be determined by executing + * Constructor. + * + * When you use this constructor, the display value will be determined by executing * the given property expression on the list object, and the id will be based on the list index. * The display value will be calculated by the given property expression * @@ -90,13 +92,13 @@ public class ChoiceRenderer<T> implements IChoiceRenderer<T> */ public ChoiceRenderer(String displayExpression) { - super(); - this.displayExpression = displayExpression; - this.idExpression = null; + this(displayExpression, null); } /** - * Construct. When you use this constructor, both the id and the display value will be + * Constructor. + * + * When you use this constructor, both the id and the display value will be * determined by executing the given property expressions on the list object. * * @param displayExpression @@ -106,14 +108,10 @@ public class ChoiceRenderer<T> implements IChoiceRenderer<T> */ public ChoiceRenderer(String displayExpression, String idExpression) { - super(); this.displayExpression = displayExpression; this.idExpression = idExpression; } - /** - * @see org.apache.wicket.markup.html.form.IChoiceRenderer#getDisplayValue(java.lang.Object) - */ @Override public Object getDisplayValue(T object) { @@ -131,9 +129,6 @@ public class ChoiceRenderer<T> implements IChoiceRenderer<T> return returnValue; } - /** - * @see org.apache.wicket.markup.html.form.IChoiceRenderer#getIdValue(java.lang.Object, int) - */ @Override public String getIdValue(T object, int index) {
