[ 
https://issues.apache.org/jira/browse/WICKET-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873907#comment-13873907
 ] 

Sven Meier commented on WICKET-4744:
------------------------------------

IMHO we should deprecate and drop #cloneModel() in 7.x:
- it's used in GoAndClearFilter only
- it's name is wrong, it's used to clone model *objects*
- it's not clear (to me) why it tries to 'avoid cloning of Component instances' 
(javadoc)

Your changes look fine to me.

> Investigate reworking WicketObjects#clone(Object|Model) methods to use 
> ISerializer
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-4744
>                 URL: https://issues.apache.org/jira/browse/WICKET-4744
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>    Affects Versions: 6.0.0
>            Reporter: Martin Grigorov
>
> WicketObject#cloneXYZ() methods use normal Java serialization to clone an 
> object/model.
> This will not work if the application uses a custom ISerializer which doesn't 
> require all objects to be Serializable.
> It is not straight forward to replace this custom code with JavaSerializer 
> because there are overrides for object replacement.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to