[ 
https://issues.apache.org/jira/browse/WICKET-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887021#comment-13887021
 ] 

Joakim Erdfelt commented on WICKET-5453:
----------------------------------------

That code snippet is sane.
Yes, that would set the idle timeout.

But I have to ask, since you have ServerApplicationConfig, and you are 
apparently using JSR-356, why not just use the JSR-356 techniques?

Example:

Using a {{ServletContainerInitializer}} you could ...

{code:java}
    pubilc void onStartup(Set<Class<?>> c, ServletContext ctx) throws 
ServletException
    {
        ServerContainer wsContainer = (ServerContainer) 
ctx.getAttribute("javax.websocket.server.ServerContainer");
        wsContainer.setDefaultMaxSessionIdleTimeout(5000);
    }
{code}

I would expect that to be the same behavior.



> Jetty 9.1.0 has its own UpgradeFilter, use it
> ---------------------------------------------
>
>                 Key: WICKET-5453
>                 URL: https://issues.apache.org/jira/browse/WICKET-5453
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-native-websocket
>    Affects Versions: 7.0.0
>            Reporter: Joakim Erdfelt
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> In a recent stackoverflow question ..
> http://stackoverflow.com/questions/20661139/websocket-timeout-with-apache-wicket-and-embedded-jetty
> I noticed a reference to a class called Jetty9WebSocketFilter
> Starting in Jetty 9.1.0, a filter for websocket upgrade ships with Jetty.
> See answer (with example code):
> http://stackoverflow.com/a/20663447/775715



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to